slt-release: don't add npmignore entries twice #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bajtos best way to test is to run slt-release without the |
| npm publish | ||
| git checkout "$BASE" | ||
| echo "You can revert .npmignore changes now." |
|
LGTM, @rmg, you have comments? |
Also tell the user what changes are being made and how to clean up after the package was published.
bajtos
force-pushed
the
feature/improve-npmignore
branch
from
5006a92
to
aa8d50b
Compare
|
Thanks for merging this without waiting for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tell the user what changes are being made and how to clean up after the package was published.
@rmg please review
cc @sam-github
I don't have a sandbox to test this change, so I didn't run the new code. What's the best way of testing slt-release without messing up github/npmjs data?