maximized window bug fix

strongqa · Aug 1, 2017 · dbe5ee1 · dbe5ee1
1 parent cdb4eba
commit dbe5ee1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/generators/config/templates/capybara.rb b/generators/config/templates/capybara.rb
@@ -52,6 +52,9 @@ module CapybaraHelpers
     options = Selenium::WebDriver::Firefox::Options.new(profile: ff_profile)
     params[:options] = options
   end
+  if CapybaraHelpers.chrome_browser?
+    params[:options] = Selenium::WebDriver::Chrome::Options.new(args: ['start-fullscreen']) if Howitzer.maximized_window
+  end
   Capybara::Selenium::Driver.new app, params
 end
 

diff --git a/lib/howitzer/web/page.rb b/lib/howitzer/web/page.rb
@@ -153,7 +153,7 @@ def ambiguous_page_msg(page_list)
 
       def initialize
         check_validations_are_defined!
-        current_window.maximize if Howitzer.maximized_window && Howitzer.driver != 'headless_chrome'
+        current_window.maximize if Howitzer.maximized_window && !chrome_browser?
       end
 
       # Reloads current page in a browser
@@ -162,6 +162,12 @@ def reload
         Howitzer::Log.info "Reload '#{current_url}'"
         visit current_url
       end
+
+      private
+
+      def chrome_browser?
+        Howitzer.driver == 'headless_chrome' || Howitzer.selenium_browser == 'chrome'
+      end
     end
   end
 end