multiple domain support #259
Conversation
1 similar comment
lib/howitzer.rb
Outdated
| @@ -37,12 +37,13 @@ def mailgun_idle_timeout | |||
| # @example returns url without auth | |||
| # app_uri.origin | |||
|
|
|||
| def self.app_uri | |||
| def self.app_uri(name = nil) | |||
There was a problem hiding this comment.
If user forgot to create the settings, howitzer needs to show Warning: You used host, but forgot to define settings, please add following settings:...
There was a problem hiding this comment.
Change log should be update
There was a problem hiding this comment.
code documentation should be extended
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ### New Features | |||
| - Cucumber rake tasks minor updates | |||
| - Add multiple domain support | |||
There was a problem hiding this comment.
We have issue for it. It means, we need to provide link to original issue
lib/howitzer.rb
Outdated
| @@ -36,14 +36,25 @@ def mailgun_idle_timeout | |||
| # app_uri.site | |||
| # @example returns url without auth | |||
| # app_uri.origin | |||
| # @example returns url for custom host(should be specified in config) | |||
There was a problem hiding this comment.
# @example returns url for custom host
# app_uri(:example).site
lib/howitzer.rb
Outdated
| ) | ||
| rescue NoMethodError |
There was a problem hiding this comment.
Looks like settings are validating in SexySettings automatically. Do we really need the message?
There was a problem hiding this comment.
If setting is not present it throws exception like this:
undefined method `example_app_base_auth_login' for Howitzer:Module (NoMethodError)
With this rescue message becomes more clear:
config is missing for custom host example, please add to config:
example_app_base_auth_login
example_app_base_auth_pass
example_app_host
example_app_protocol (NoMethodError)
1 similar comment
#257