Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed phantomjs support #275

Merged
merged 3 commits into from Mar 1, 2018
Merged

Removed phantomjs support #275

merged 3 commits into from Mar 1, 2018

Conversation

mikhaillopandia
Copy link
Contributor

@coveralls
Copy link

coveralls commented Feb 28, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling dddecea on #274 into 481ea5e on master.

@mikhaillopandia
Copy link
Contributor Author

Selenium doesn't support PhantomJS anymore:

For Opera, users should be able to simply rely on testing Chrome as the Opera browser is based on Chromium (and the operadriver was a thin wrapper around chromedriver). 
For PhantomJS, users should use Chrome or Firefox in headless mode (see example/headless.js)

https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md#changes-to-supported-browsers

# testingbot, browserstack, crossbrowsertesting, headless_chrome, appium
driver: phantomjs
driver: selenium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about Selenium+Firefox as default for the framework. I would use either headless_chrome or poltergeist

@mikhaillopandia mikhaillopandia merged commit daa4c76 into master Mar 1, 2018
@mikhaillopandia mikhaillopandia deleted the #274 branch March 1, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants