Update wolfSSL plugin for strongSwan to resolve build conflicts #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-weller-wolfssl
force-pushed
the
wolfssl-strongswan-update
branch
2 times, most recently
from
d1cf326
to
005fd9d
Compare
tim-weller-wolfssl
force-pushed
the
wolfssl-strongswan-update
branch
2 times, most recently
from
5e83b77
to
fd99ba3
Compare
tobiasbrunner
requested changes
Nov 2, 2022
tim-weller-wolfssl
force-pushed
the
wolfssl-strongswan-update
branch
from
fd99ba3
to
8985071
Compare
tim-weller-wolfssl
force-pushed
the
wolfssl-strongswan-update
branch
from
8985071
to
ad7ec62
Compare
|
I've pushed this (with the move of the include) to the 1332-wolfss-build branch. Please let me know if that works for you. |
|
I ran the strongSwan + wolfSSL tests used to develop the changes in this branch with the changes pushed to the 1332-wolfssl-build branch and all the test configurations passed, so the changes in the 1332-wolfssl-build branch work for me. Thank-you for pushing the changes forward! |
|
Great, thanks for testing. I've pushed the change to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the strongSwan (libstrongswan) wolfSSL plugin to resolve build conflicts with the latest wolfSSL code-base to support the strongSwan + wolfSSL + FIPS use case.
Testing
Testing used the libstrongswan test, following the process found on the strongSwan + wolfSSL + FIPS page, with the test passing at expected levels: all tests pass except the RSA 1536-bit key-size, which is not supported by the wolfCrypt FIPS module used.