Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Fix compile error when import a different driver. #80

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Fix compile error when import a different driver. #80

merged 1 commit into from
Jun 21, 2016

Conversation

djx314
Copy link
Contributor

@djx314 djx314 commented Jun 18, 2016

When I use play-slick with slick. If I define a table out of the dao class, I need to import a different driver.api._ to create the EntityTable. And If the EntityActions use driver.Table it will compile fail. So this pr use RelationalProfile#Table, hope for fix it. ( like slick/slick#1281 , and the issue is slick/slick#1253 )

@octonato octonato merged commit 3d95dfb into strongtyped:develop Jun 21, 2016
@octonato
Copy link
Contributor

Thanks for that @djx314

@octonato
Copy link
Contributor

Hi @djx314,

Slick issue (slick/slick#1274) is fixed. Since it's an important bug fix, I do expect a new slick release soon.

As soon it's out, I will update active-slick and make a new release containing this PR.

This is also solve the issue (#78) you filled some time ago.

@djx314
Copy link
Contributor Author

djx314 commented Jun 30, 2016

Oh, that's great !
slick/slick#1537
Just waiting for this Friday.

@djx314
Copy link
Contributor Author

djx314 commented Jul 4, 2016

@rcavalcanti slick 3.2.0-M1 is out. Some base api is changed basause I update my framework's version and it compiled failed. Have a try in active-slick?

@djx314
Copy link
Contributor Author

djx314 commented Jul 5, 2016

@rcavalcanti A pr is available with scala 2.11 and 2.12-M5 in #82 Hope for reviewing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants