Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL parser does not seem to handle curly brackets balance #252

Closed
GuillaumeTaffin opened this issue Feb 23, 2024 · 0 comments
Closed

DSL parser does not seem to handle curly brackets balance #252

GuillaumeTaffin opened this issue Feb 23, 2024 · 0 comments
Labels

Comments

@GuillaumeTaffin
Copy link
Contributor

Description

While using the StructurizrDslParser from "com.structurizr:structurizr-dsl:2.0.0" lib, trying out simple validation made by the parser. I noticed that there are no errors if the "{", "}" of a workspace are not balanced.

The workspace output by the parser is actually valid.

Steps to reproduce

  1. Take the simple workspace dsl example from https://structurizr.com/ (top of the page)
  2. Go to https://structurizr.com/dsl and paste the code there
  3. Remove the last "}" which closes the workspace
  4. Render the dsl
  5. No error in rendering :(

The same can be easily reproduced in a few line of code (I put a screen shot of a failing test written in kotlin where I expected the parser to fail to parse)

Screenshot

image

Code sample

No response

Configuration

No response

Severity

Minor

Priority

I have no budget and there's no rush, please fix this for free

More information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant