Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram writer interface to be able to produce multiple files #61

Closed
Zaijo opened this issue Oct 31, 2017 · 2 comments
Closed

Diagram writer interface to be able to produce multiple files #61

Zaijo opened this issue Oct 31, 2017 · 2 comments

Comments

@Zaijo
Copy link
Contributor

Zaijo commented Oct 31, 2017

In case of PlantUML, the processor to image expects to receive one diagram at a time.

Current interface of writers doesn't allow returning multiple diagrams separately. I had to split the string on "@startuml" line and save as individual files.

@simonbrowndotje
Copy link
Contributor

I might change the name before a Maven release (and it needs some tests), but I've added a toPlantUML() method that returns a collection of Strings, one per diagram -> https://github.com/structurizr/java/blob/master/structurizr-core/src/com/structurizr/io/plantuml/PlantUMLWriter.java#L60

@Zaijo
Copy link
Contributor Author

Zaijo commented Nov 5, 2017

Very well, that does the job (I only looked at the method signature). Thanks.

Well, how do you close issues like this?

  • Accepted to master -> done?

or

  • Part of a new release -> done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants