AmazonWebServicesS3WorkspaceDao.GetWorkspaceMetaData occurs java.lang.OutOfMemoryError

[cavies]

java.lang.OutOfMemoryError: Java heap space
at java.base/java.util.Properties$LineReader.readLine(Unknown Source)
at java.base/java.util.Properties.load0(Unknown Source)
at java.base/java.util.Properties.load(Unknown Source)
at com.structurizr.onpremises.component.workspace.AmazonWebServicesS3WorkspaceDao.getWorkspaceMetaData(AmazonWebServicesS3WorkspaceDao.java:271)
at com.structurizr.onpremises.component.workspace.AbstractWorkspaceDao.getWorkspaces(AbstractWorkspaceDao.java:21)
at com.structurizr.onpremises.component.workspace.WorkspaceComponentImpl.getWorkspaces(WorkspaceComponentImpl.java:65)
at com.structurizr.onpremises.component.workspace.WorkspaceComponentImpl.getWorkspaces(WorkspaceComponentImpl.java:73)
at com.structurizr.onpremises.web.home.HomePageController.show(HomePageController.java:47)
at com.structurizr.onpremises.web.home.HomePageController.showDashboardPage(HomePageController.java:43)
at com.structurizr.onpremises.web.home.HomePageController.showHomePage(HomePageController.java:29)
at com.structurizr.onpremises.web.home.HomePageController$$FastClassBySpringCGLIB$$a2b80b9e.invoke()
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy.invokeMethod(CglibAopProxy.java:386)
at org.springframework.aop.framework.CglibAopProxy.access$000(CglibAopProxy.java:85)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:704)
at com.structurizr.onpremises.web.home.HomePageController$$EnhancerBySpringCGLIB$$e92e9099.showHomePage()
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:895)
at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:808)
at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1071)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:964)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006)
at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:670)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883)
[WARN ] 2023-03-16 07:05:03.572 [http-nio-8080-exec-3] S3AbortableInputStream - Not all bytes were read from the S3ObjectInputStream, aborting HTTP connection. This is likely an error and may result in sub-optimal behavior. Request only the bytes you need via a ranged GET or drain the input stream after use.
java.lang.OutOfMemoryError: Java heap space
at java.base/java.util.Properties$LineReader.readLine(Unknown Source)
at java.base/java.util.Properties.load0(Unknown Source)
at java.base/java.util.Properties.load(Unknown Source)
at com.structurizr.onpremises.component.workspace.AmazonWebServicesS3WorkspaceDao.getWorkspaceMetaData(AmazonWebServicesS3WorkspaceDao.java:271)
at com.structurizr.onpremises.component.workspace.AbstractWorkspaceDao.getWorkspaces(AbstractWorkspaceDao.java:21)
at com.structurizr.onpremises.component.workspace.WorkspaceComponentImpl.getWorkspaces(WorkspaceComponentImpl.java:65)
at com.structurizr.onpremises.component.workspace.WorkspaceComponentImpl.getWorkspaces(WorkspaceComponentImpl.java:73)
at com.structurizr.onpremises.web.home.HomePageController.show(HomePageController.java:47)
at com.structurizr.onpremises.web.home.HomePageController.showDashboardPage(HomePageController.java:43)
at com.structurizr.onpremises.web.home.HomePageController.showHomePage(HomePageController.java:29)
at com.structurizr.onpremises.web.home.HomePageController$$FastClassBySpringCGLIB$$a2b80b9e.invoke()
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at org.springframework.aop.framework.CglibAopProxy.invokeMethod(CglibAopProxy.java:386)
at org.springframework.aop.framework.CglibAopProxy.access$000(CglibAopProxy.java:85)
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:704)
at com.structurizr.onpremises.web.home.HomePageController$$EnhancerBySpringCGLIB$$e92e9099.showHomePage()
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150)
at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:117)

[simonbrowndotje]

Have you tried increasing the Java heap size?

[cavies]

Yes, but it doesn't seem to work. I guess it's a specific json file that caused the problem. Wait a moment, I'll submit the corresponding json file in the workspace as soon as possible

[cavies]

I think I know where the problem is. The problem is in workspace.properties/description.

In fact, there is only one sentence in this description. In workspace.json
"description":"iDox.ai provides the world’s most advanced AI powered solution for organization"
I don't know why workspace. properties/description becomes garbled.

[cavies]

This problem is like this. At the beginning, the description was written in Chinese. Then the display on the UI appears garbled. I read the relevant code, and I think the problem should be the following.

When saving, you encode properties as byte code in utf_8 then stored. However, it is directly read from binary bytecode.

Should we first convert from binary bytecode to utf_8 characters, then load
maybe like that:

inputStream = amazonS3.getObject(getRequest).getObjectContent();
Properties properties = new Properties();
properties.load(new InputStreamReader(inputStream, StandardCharsets.UTF_8));

[simonbrowndotje]

Thanks, yes, this seems to resolve the issue when using S3.

[cavies]

Please see issue #33