Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package.json? #1

Closed
aviflax opened this issue Nov 19, 2018 · 2 comments
Closed

Missing package.json? #1

aviflax opened this issue Nov 19, 2018 · 2 comments

Comments

@aviflax
Copy link

aviflax commented Nov 19, 2018

Thanks for creating this repo! It’s super helpful.

One minor problem: the readme doesn’t say how to download the dependencies, and one can’t just run npm install (which AFAIK is the usual way to install the deps of a node program) because package.json isn’t included in the repo.

So maybe it should be included?

Alternatively, I figured out that I can just run npm install puppeteer and that works just fine. So another option might be to remove package-lock.json and add some instructions to the README that users should simply run npm install puppeteer? I’d be happy to contribute such a change as a pull request if you’d like.

@simonbrowndotje
Copy link
Contributor

Thanks, yes, the package-lock.json file shouldn't have been committed, so I've removed it. Installing Puppeteer is relatively straightforward although, IIRC, the first time I did it I had to install npm, which I think meant installing brew too, which also meant updating something else first. Since I'd rather not get into debugging Puppeteer installations, I've just added a link to the Puppeteer website. 🙂

@aviflax
Copy link
Author

aviflax commented Nov 19, 2018

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants