Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis no longer green on master #130

Closed
fancycode opened this issue Oct 20, 2015 · 8 comments
Closed

Travis no longer green on master #130

fancycode opened this issue Oct 20, 2015 · 8 comments

Comments

@fancycode
Copy link
Member

Travis is no longer green on master after commit 0338ac5:
https://travis-ci.org/strukturag/libde265/builds/85284996

Also the fuzzing streams are failing after commit 8ec4e93:
https://travis-ci.org/strukturag/libde265/builds/85519474

Please check and make sure to keep Travis green/stable at least on the master branch in the future.

@farindk
Copy link
Contributor

farindk commented Oct 20, 2015

I tried to fix the CMakefile to find this include file, but could not
see where to add the path.


/home/travis/build/strukturag/libde265/dist-cmake-test/libde265-1.0.2/enc265/enc265.cc:30:10:
fatal error:

  'image-io-png.h' file not found

#include "image-io-png.h"

     ^

1 error generated.

2015-10-20 14:12 GMT+02:00 Joachim Bauch notifications@github.com:

Travis is no longer green on master after commit 0338ac5
0338ac5
:
https://travis-ci.org/strukturag/libde265/builds/85284996

Also the fuzzing streams are failing after commit 8ec4e93
8ec4e93
:
https://travis-ci.org/strukturag/libde265/builds/85519474

Please check and make sure to keep Travis green/stable at least on the
master branch in the future.


Reply to this email directly or view it on GitHub
#130.

@fancycode
Copy link
Member Author

It is using the result of make dist which then fails to compile, maybe the header is new and not included in the distribution tarball?

@farindk
Copy link
Contributor

farindk commented Oct 20, 2015

That could be the reason.

However, I think it also failed when I tried to build it locally with cmake
without 'make dist'. Then I gave up.

2015-10-20 14:19 GMT+02:00 Joachim Bauch notifications@github.com:

It is using the result of make dist which then fails to compile, maybe
the header is new and not included in the distribution tarball?


Reply to this email directly or view it on GitHub
#130 (comment)
.

@fancycode
Copy link
Member Author

cmake without make dist is also tested, that works:
https://travis-ci.org/strukturag/libde265/jobs/85562561

@farindk
Copy link
Contributor

farindk commented Oct 20, 2015

Then it sounds like a simple fix.

2015-10-20 14:25 GMT+02:00 Joachim Bauch notifications@github.com:

cmake without make dist is also tested, that works:
https://travis-ci.org/strukturag/libde265/jobs/85562561


Reply to this email directly or view it on GitHub
#130 (comment)
.

@fancycode
Copy link
Member Author

The missing file most likely yes, but I don't know about the fuzzing streams. Maybe you added an assertion somewhere that now fires?

@farindk
Copy link
Contributor

farindk commented Oct 20, 2015

Most probably an unavailable reference to a SPS or PPS header which are now
managed through shared_ptr<>s. Not too concerned about it. Will check later.

2015-10-20 14:31 GMT+02:00 Joachim Bauch notifications@github.com:

The missing file most likely yes, but I don't know about the fuzzing
streams. Maybe you added an assertion somewhere that now fires?


Reply to this email directly or view it on GitHub
#130 (comment)
.

@farindk
Copy link
Contributor

farindk commented Apr 17, 2018

all green again

@farindk farindk closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants