Various improvements to the updated Go library and example app #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
requested changes
Aug 31, 2018
There was a problem hiding this comment.
Thanks, left some comments. I think you also need to rebase to fix this error:
https://travis-ci.org/strukturag/libheif/jobs/418152407
go/heif/heif.go
Outdated
| @@ -94,12 +94,12 @@ const ( | |||
| ProgressStepLoadTile = C.heif_progress_step_load_tile | |||
| ) | |||
|
|
|||
| // --- HeifError | |||
There was a problem hiding this comment.
We want to expose the HeifError so users can cast the returned error to HeifError and inspect the actual error.
go/heif/heif.go
Outdated
|
|
||
| type ErrorCode int | ||
| type errorCode int |
go/heif/heif.go
Outdated
| ) | ||
|
|
||
| type ErrorSubcode int | ||
| type errorSubcode int |
go/heif/heif.go
Outdated
| type HeifError struct { | ||
| Code ErrorCode | ||
| Subcode ErrorSubcode | ||
| type heifError struct { |
go/heif/heif.go
Outdated
| @@ -694,6 +690,7 @@ func decodeConfig(r io.Reader) (image.Config, error) { | |||
| } | |||
|
|
|||
| func init() { | |||
| image.RegisterFormat("heif", "\x00\x00\x00\x18\x66\x74\x79\x70", decodeImage, decodeConfig) | |||
There was a problem hiding this comment.
Please move below the other RegisterFormat and update the comment.
|
Rebased to master & addressed your comments. PTAL @fancycode |
fancycode
reviewed
Sep 4, 2018
| if err.Code == ErrorUnsupportedFiletype { | ||
| fmt.Println("XXX") | ||
| } | ||
| return err |
There was a problem hiding this comment.
The return err should remain (see Travis errors).
There was a problem hiding this comment.
Oopsie, fixed.
leonklingele-work
force-pushed
the
goify2
branch
from
772654d
to
1d3b94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ID, etc.)