Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Context to clients / sessions. #732

Merged
merged 1 commit into from
May 16, 2024
Merged

Add Context to clients / sessions. #732

merged 1 commit into from
May 16, 2024

Conversation

fancycode
Copy link
Member

The Context will be closed when the client disconnects / the session is removed, so any pending requests can be cancelled.

@coveralls
Copy link

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9108015094

Details

  • 62 of 71 (87.32%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.002%) to 54.391%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hub.go 44 45 97.78%
clientsession.go 11 13 84.62%
grpc_remote_client.go 0 3 0.0%
virtualsession.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
client.go 2 74.64%
clientsession.go 2 63.68%
grpc_remote_client.go 2 75.57%
Totals Coverage Status
Change from base Build 9107809001: 0.002%
Covered Lines: 8256
Relevant Lines: 15179

💛 - Coveralls

The Context will be closed when the client disconnects / the session is removed,
so any pending requests can be cancelled.
@fancycode fancycode merged commit 0b259a8 into master May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants