Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ringing stopped working for outgoing calls #377

Closed
fancycode opened this issue Oct 25, 2016 · 0 comments
Closed

Ringing stopped working for outgoing calls #377

fancycode opened this issue Oct 25, 2016 · 0 comments
Assignees
@fancycode

Comments

@fancycode
Copy link
Member

The refactoring to support conference calls broke the ringing for outgoing calls as the "PeerCall.isOutgoing()" seems to return the wrong value, causing the check in

spreed-webrtc/static/js/controllers/uicontroller.js

Line 477 in 9bb8426

if (peercall && peercall.isOutgoing()) {
to fail.
@fancycode fancycode self-assigned this Oct 25, 2016
fancycode added a commit to fancycode/spreed-webrtc that referenced this issue Oct 25, 2016
@fancycode
Explicitly pass "outgoing" flag when creating PeerCall object.
fc3f66b 
This fixes strukturag#377 where no ringing sound was played back because the call
was not seen as "outgoing" (and also fixes the missing timeout if the
called peer does not pick up).
@fancycode fancycode mentioned this issue Oct 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fancycode fancycode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fancycode