Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon proposal + disabling FFZ #2

Open
Zabriskije opened this issue Dec 6, 2022 · 5 comments
Open

New icon proposal + disabling FFZ #2

Zabriskije opened this issue Dec 6, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Zabriskije
Copy link

Hi @strumswell!
I've made a new app icon to thank you for taking BTTV and FFZ to Safari. In case you like it, feel free to use it.
I've also included in this zip the logo alone for the toolbar.

And, to not open another issue: in case I don't want to use FFZ, there's a way I can disable it?
I've tried removing the injection from content.js located in /BTTV for Safari.app/Contents/PlugIns/BTTV for Safari Extension.appex/Contents/Resources:

// Inject FFZ script
const ffzScript = document.createElement('script');
ffzScript.type = 'text/javascript';
ffzScript.src = 'https://cdn.frankerfacez.com/static/ffz_injector.user.js';
+
head.appendChild(ffzScript);

but if I do that, Safari reports that the entry "icons" in manifest.js failed to load (wut?).

@strumswell
Copy link
Owner

Thank you SO much for spending time on creating such an amazing app icon. I will definitely use that one in an updated version, including your request concerning some toggles for the FFZ and BTTV script injection.

Please give me some time. I will try to incorporate these changes this weekend and will probably also upload it to the App Store as a second distribution channel. (I still have a paid dev account lying around)

Let me say it again: THANK YOU. 🎉

@Zabriskije
Copy link
Author

Whoa! 😳 Glad you liked it.
Unfortunately I've just realized that is a bit too flat, so I'm sorry but here's a better one:

Take your time, download the new zip, and hit me up if you need something else.

@strumswell
Copy link
Owner

Thank you again for the logo and your feature request. I included the new app/ toolbar icon and added your request regarding disabling FFZ. If you click on the toolbar icon, a popup should appear. In there, you can simply check or uncheck BTTV or FFZ to get them injected or not when visiting Twitch.

I still have a few minor things to iron out but I want you to test this release if you are free. :) Let me know what you think and if you have any issues.

Download: BTTV for Safari.zip

@Zabriskije
Copy link
Author

Tried out, everything is working properly, good job!
The toolbar icon seems too thick to me, what do you think?
I've made a thinner one in case you agree:

@strumswell
Copy link
Owner

Yeah, I noticed this as well but could live with it. Good that you thought so as well, because the thinner variant will definitely look better. ;)

I'll keep you updated.

@strumswell strumswell self-assigned this Dec 10, 2022
@strumswell strumswell added the enhancement New feature or request label Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants