This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
feat: add typings for all packages in the project 馃帀 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrossmann
added
enhancement
work in progress
This issue is currently being worked on
documentation
labels
Nov 27, 2018
robertrossmann
force-pushed
the
feat/typings
branch
from
November 29, 2018 15:22
1d02d88
to
b456579
Compare
robertrossmann
changed the title
feat(atlas): add typings for the whole @atlas.js/atlas package 馃帀
feat(atlas): add typings for all packages in the project 馃帀
Dec 4, 2018
robertrossmann
changed the title
feat(atlas): add typings for all packages in the project 馃帀
feat: add typings for all packages in the project 馃帀
Dec 4, 2018
This also demonstrates the idea behind type-hinting the component instances users receive when using `this.component(alias)` from within their components.
Useful when doing custom stuff and you need access to mongoose internals. Also great for type hinting to some extent.
robertrossmann
force-pushed
the
feat/typings
branch
from
December 6, 2018 13:12
deaeb83
to
e981ce2
Compare
- @atlas.js/action@1.2.0-alpha.0 - @atlas.js/atlas@2.2.0-alpha.0 - @atlas.js/aws@2.1.0-alpha.0 - @atlas.js/braintree@2.1.0-alpha.0 - @atlas.js/cli@1.2.0-alpha.0 - @atlas.js/component@2.2.0-alpha.0 - @atlas.js/errors@0.3.0-alpha.0 - @atlas.js/firebase@2.1.0-alpha.0 - @atlas.js/generator-atlas@2.3.0-alpha.0 - @atlas.js/hook@2.1.0-alpha.0 - @atlas.js/koa@3.2.0-alpha.0 - @atlas.js/mongoose@3.2.0-alpha.0 - @atlas.js/nodemailer@2.1.0-alpha.0 - @atlas.js/objection@2.2.0-alpha.0 - @atlas.js/repl@2.1.0-alpha.0 - @atlas.js/sequelize@2.1.0-alpha.0 - @atlas.js/service@1.2.0-alpha.0 - @atlas.js/templates@1.1.0-alpha.0
Merging now. Typed components are now released under npm's Documentation and any potential fixes to the type data will be done in a separate PR. |
robertrossmann
removed
the
work in progress
This issue is currently being worked on
label
Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs work, but the basic API surface is typed now! 馃挭
To do:
Atlas
Action
,Service
,Hook
@atlas.js/aws
@atlas.js/braintree
@atlas.js/cli
@atlas.js/errors
@atlas.js/firebase
@atlas.js/generator-atlas
@atlas.js/koa
@atlas.js/mongoose
@atlas.js/nodemailer
@atlas.js/objection
@atlas.js/repl
@atlas.js/sequelize
@atlas.js/templates
atlas.actions.
in an editor would show all known actions for this instance 馃挭this.component('service:objection')
to show proper hints for that service etc.Closes strvcom/backend-docs#68
Closes #55