Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

Week5 homework #11

Merged
merged 10 commits into from
Apr 24, 2019
Merged

Week5 homework #11

merged 10 commits into from
Apr 24, 2019

Conversation

arnostpleskot
Copy link
Contributor

Hello! This is PR of homework for week 5.

@varholak-peter varholak-peter changed the title [WIP] Week5 homework Week5 homework Apr 21, 2019
@developer239
Copy link
Contributor

developer239 commented Apr 21, 2019 •
edited
Loading

It looks like my tests are failing 🙂 edit: a fix is mentioned somewhere bellow

`[pages] SignUp › when form submit › when success › should redirect user to account page`
`[pages] SignIn › when form submit › when success › should redirect user to account page`
`[pages] Account › when not logged in › should redirect to login page`

dannytce
dannytce reviewed Apr 22, 2019
View reviewed changes
src/pages/Cart/index.js Outdated Show resolved Hide resolved
dannytce
dannytce reviewed Apr 22, 2019
View reviewed changes
src/pages/LogIn/index.js Outdated Show resolved Hide resolved
dannytce
dannytce suggested changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@dannytce dannytce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job guys! :)

We found a few nitpicks and actually one bug. Please take a look at it 💪

src/pages/ProductList/index.js Outdated Show resolved Hide resolved
src/pages/SignUp/index.js Outdated Show resolved Hide resolved
src/store/cart/reducer.js Outdated
@@ -8,9 +9,7 @@ const reducer = (state = {}, action) => {
[action.payload]: (state[action.payload] || 0) + 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's ramdify this one too? :)

@arnostpleskot
Copy link
Contributor Author

I've fixed most of the comments, rest I'll leave to @varholak-peter 😁

@arnostpleskot
Copy link
Contributor Author

@dannytce check 164917e

@dannytce dannytce merged commit 1f75a54 into master Apr 24, 2019
@dannytce dannytce deleted the week5-homework branch April 24, 2019 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannytce dannytce dannytce approved these changes

@prichodko prichodko Awaiting requested review from prichodko

@varholak-peter varholak-peter Awaiting requested review from varholak-peter

@developer239 developer239 Awaiting requested review from developer239

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arnostpleskot @developer239 @dannytce @varholak-peter