Tests #12
Tests #12
Conversation
- we are testing action in our reducer integration test
- just to show how coverage works and why button was not 100 % covered
- create render with router helper - create basic test case
- add fetch-mock dev dependency - mock GET /api/skus - mock POST /oauth/token
- initialize redux store with mock data - update cart item component so that we can differentiate between loaded and not loaded state
- test unsuccessful submit - test successful submit
…hts-2018-private into tests # Conflicts: # src/components/Layout/index.js # src/pages/Cart/CartItem.js # src/pages/LogIn/index.js # src/pages/SignUp/index.js
There was a problem hiding this comment.
Wow, usually after a long ride on a bike I am not writing 2k lines of code 😅 Please consider if it's not too much (especially thinking of missing cypress example). In the end, you need to present all the stuff for 1 hour. That might be a bit overwhelming both for you and students.
Anyway thank you very much for contribution! Now let's take a look more deeper
-
Regarding
[DO NOT MERGE YET]. There is aDraft Pull Requestfor these purposes. Or personally, I prefer to put[WIP]prefix in front of the name of PR. -
Let's get rid of
index.test.jsand name it properly according what this test is going. E.g.Button/tests/index.test.jswill become aButton/tests/Button.test.js -
There is too much snapshot testing. I would rather try to avoid it and bring in actual testing.
-
I left there a few comments, please take a look on them.
- fix naming in reducer test - rename test files from index.test.js to [testee].test.js - replace some snapshots with normal jest expectations
…-private into tests # Conflicts: # src/components/Layout/index.js # src/components/Pagination/SizeSelect.js # src/pages/Cart/CartItem.js # src/pages/Cart/index.js # src/pages/LogIn/index.js # src/pages/ProductList/index.js # src/pages/SignUp/index.js # src/store/cart/reducer.js # yarn.lock
Because I had a pretty long bike ride yesterday, I decided to write some tests. My PR works fine with week 5 homework. It is going to be interesting to see what happens when we add some redux middleware.
However, I am pretty confident that my tests will not break because I am not testing implementation.
On the backend, I am usually writing tests for controllers (routes) Here I also decided to test individual routes. (pages)
A possible disadvantage is that one test can fail for many different reasons. However, I am kind of OK with that because I want my tests to fail if there is a bug somewhere.
With that said I am definitely not an expert so I would appreciate a review. 🙂
TODO: