Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Version incompatibilities with code-quality-tools #22

Closed
lucasconstantino opened this issue Apr 25, 2019 · 1 comment
Closed

Version incompatibilities with code-quality-tools #22

lucasconstantino opened this issue Apr 25, 2019 · 1 comment

Comments

@lucasconstantino
Copy link

lucasconstantino commented Apr 25, 2019

This package is currently released on NPM at version 2.1.1, while master in this repo has been on 3.0.0 for a while now. This version difference implies some breaking changes which prevent this package from being used aside other @strvcom tools such as strvcom/code-quality-tools's @strv/eslint-config-react.

Right now I'm having an issue with ESLint rule react/no-unsafe, which in previous version had no argument, but now has checkAliases option. @strv/eslint-config-react uses this new option, but @strv/react-scripts directly depends on an outdated version of eslint-plugin-react - thus causing the issue.

I'll place the complete error here for the sake of search engines:

Error: @strv/eslint-config-react:
	Configuration for rule "react/no-unsafe" is invalid:
	Value [{"checkAliases":true}] should NOT have more than 0 items.
@lucasconstantino lucasconstantino changed the title Desperately need a new release Version incompatibilities with code-quality-tools Apr 25, 2019
@prichodko
Copy link

Thanks for bringing this up. @strv/react-scripts has been upgraded to v3, let me know if it fixes the issue 👍 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants