fix(karma-runner): support zero-mutant runs (#3787)

Fix a bug that blocked users from performing a run without mutating files.
stryker-mutator · Oct 19, 2022 · c6a9219 · c6a9219
1 parent f0e519b
commit c6a9219
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -52,7 +52,10 @@ To run local changes you made in StrykerJS in an actual project you have two opt
     ```sh
     cd my-project
     open stryker.conf.json 
-    # Add `"plugins": ["/home/username/stryker-js/packages/jest-runner"]` inside the stryker.conf.json
+     # Add `"plugins": ["/home/username/stryker-js/packages/karma-runner/dist/src/index.js"]` inside the stryker.conf.json
+     #   If you use typescript checker and you get an error :  Cannot find Checker plugin "typescript"
+     #   then add the typescript checker local path to the `plugin` as well:
+     #   "plugins": ["/Users/username/stryker-js/packages/karma-runner/dist/src/index.js",  "/Users/username/stryker-js/packages/typescript-checker/dist/src/index.js"],
     /home/username/stryker-js/packages/core/bin/stryker run
     ```
     This way you can also debug from vscode using the "Attach" configuration and running Stryker from `my-project` like this: `node --inspect-brk /home/username/stryker-js/packages/core/bin/stryker run`.

diff --git a/packages/karma-runner/src/karma-plugins/test-hooks-middleware.ts b/packages/karma-runner/src/karma-plugins/test-hooks-middleware.ts
@@ -84,19 +84,20 @@ export class TestHooksMiddleware {
   }
 
   private configurePerTestCoverageAnalysis() {
+    this.currentTestHooks = ` 
+    window.${SHOULD_REPORT_COVERAGE_FLAG} = true;
+    window.${NAMESPACE} = window.${NAMESPACE} || {};`;
     switch (this.testFramework) {
       case 'jasmine':
-        this.currentTestHooks = `
-      window.${SHOULD_REPORT_COVERAGE_FLAG} = true;
+        this.currentTestHooks += `
       jasmine.getEnv().addReporter({
         specStarted: function (spec) {
           window.${NAMESPACE}.${CURRENT_TEST_ID} = spec.id;
         }
       });`;
         break;
       case 'mocha':
-        this.currentTestHooks = `
-        window.${SHOULD_REPORT_COVERAGE_FLAG} = true;
+        this.currentTestHooks += `
         beforeEach(function() {
           window.${NAMESPACE}.${CURRENT_TEST_ID} = this.currentTest && this.currentTest.fullTitle();
         });

diff --git a/packages/karma-runner/test/unit/karma-plugins/test-hooks-middleware.spec.ts b/packages/karma-runner/test/unit/karma-plugins/test-hooks-middleware.spec.ts
@@ -38,6 +38,7 @@ describe(TestHooksMiddleware.name, () => {
         expect(sut.currentTestHooks)
           .contains('window.__strykerShouldReportCoverage__ = true')
           .contains('window.__stryker__.currentTestId = spec.id')
+          .contains('window.__stryker__ = window.__stryker__ || {};')
           .and.contains('jasmine.getEnv().addReporter(')
           .and.not.contains('beforeEach(function() {');
       });
@@ -48,6 +49,7 @@ describe(TestHooksMiddleware.name, () => {
         expect(sut.currentTestHooks)
           .contains('window.__strykerShouldReportCoverage__ = true')
           .contains('window.__stryker__.currentTestId = this.currentTest && this.currentTest.fullTitle()')
+          .contains('window.__stryker__ = window.__stryker__ || {};')
           .and.contains('beforeEach(function() {')
           .and.not.contains('jasmine.getEnv().addReporter(');
       });