Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base timeout is not saved when queuing a test #16

Closed
simondel opened this issue Feb 16, 2016 · 1 comment
Closed

Base timeout is not saved when queuing a test #16

simondel opened this issue Feb 16, 2016 · 1 comment
Labels
🐛 Bug Something isn't working

Comments

@simondel
Copy link
Member

The base timeout is not saved with the properties of a test when it is placed in a queue. This timeout is read from the config when the test is ran. In many cases, the timeout has already been overwritten by the base timeout of another test.

@simondel simondel added the 🐛 Bug Something isn't working label Feb 26, 2016
@simondel simondel added this to the v1.0.0 milestone Feb 26, 2016
@simondel
Copy link
Member Author

simondel commented Apr 4, 2016

This issue is no longer relevant due to the new setup with properly isolated test runners

@simondel simondel closed this as completed Apr 4, 2016
simondel pushed a commit that referenced this issue Apr 21, 2017
* fix(TestRunner): Remove stopper

Do **not** use the karma.stopper to dispose the test runner. It will kill the current process instead of closing the browser.

* refactor\(typo\): Fix typo in comments
simondel pushed a commit that referenced this issue Apr 21, 2017
* fix(TestRunner): Remove stopper

Do **not** use the karma.stopper to dispose the test runner. It will kill the current process instead of closing the browser.

* refactor\(typo\): Fix typo in comments
sanderkoenders pushed a commit that referenced this issue Jul 6, 2018
nicojs pushed a commit that referenced this issue Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant