Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumenter): don't mutate generics #2530

Merged
merged 1 commit into from
Oct 7, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/instrumenter/src/util/syntax-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ const tsTypeAnnotationNodeTypes: ReadonlyArray<types.Node['type']> = Object.free
'TSModuleDeclaration',
'TSEnumDeclaration',
'TSDeclareFunction',
'TSTypeParameterInstantiation',
]);

const flowTypeAnnotationNodeTypes: ReadonlyArray<types.Node['type']> = Object.freeze([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ describe('babel-transformer', () => {
expectMutateNotCalledWith((t) => t.isVariableDeclaration());
expectMutateNotCalledWith((t) => t.isStringLiteral());
});

it('should skip generic parameters', () => {
const ast = createTSAst({ rawContent: 'React.useState<string | false>()' });
transformBabel(ast, mutantCollectorMock, context);
expectMutateNotCalledWith((t) => t.isTSTypeParameterInstantiation());
});
});

it('should skip import declarations', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ export declare const globalNamespace = "globalNamespace";
declare function foo(): 'foo';
declare module 'express' {
}

React.useState<false>();
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
exports[`instrumenter integration type declarations should not produce mutants for a TS declaration file 1`] = `
"export declare const globalNamespace = \\"globalNamespace\\";
declare function foo(): 'foo';
declare module 'express' {}"
declare module 'express' {}
React.useState<false>();"
`;