Refactor logging #94
Refactor logging #94
Conversation
| @@ -102,6 +104,13 @@ export default class Stryker { | |||
| }); | |||
| } | |||
|
|
|||
| private freezeConfig() { | |||
| freezeRecursively(this.config); | |||
| if (log.isDebugEnabled()) { | |||
There was a problem hiding this comment.
Is this check added for performance reasons as you don't want to spend time stringifying the config the user does not even see the log message?
There was a problem hiding this comment.
Yes correct. Its a minor thing but sometimes it might be usefull
Op 22 apr. 2016 08:55 schreef "Simon de Lang" notifications@github.com:
In src/Stryker.ts
#94 (comment):
@@ -102,6 +104,13 @@ export default class Stryker {
});
}
- private freezeConfig() {
- freezeRecursively(this.config);
- if (log.isDebugEnabled()) {
Is this check added for performance reasons as you don't want to spend time
stringifying the config the user does not even see the log message?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/stryker-mutator/stryker/pull/94/files/c6d9d2b7e42d56de0419cc0b75d55379b38047a5#r60697760
|
Looks good! |
* refactor(Stryker.ts) Use log4js in stryker * refactor(TestRunnerOrchestrator.ts) Use log4js in the test runner orchestrator * refactor(install-module) Fix for integration test * refactor(IsolatedTestRunnerAdapter.ts) Use log4js in the isolated test runner adapter * refactor(Stryker) Add logging for read config * refactor(TestRunnerOrchestrator) Rename TestRunnerMetadata to TestRunnerSandbox * refactor(IsolatedTestRunnerAdapter) Add a test before trace logging * refactor(general) Replace last console.log statements with log4js log statements * docs(readme) Remove notification about migration to log4js
log.tracemethod.