feat(mocha options): Add support for mocha options #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for *some* mocha options to be passed to the `mocha` instance in the stryker-mocha-runner. The implementation uses a `ConfigEditor` to edit stryker config on the fly.
You can either pass a mocha.opts file using `mochaOptions: { opts: 'mocha.opts' }`, or pass values directly using `mochaOptions: { ui: 'qunit' }`.
Moved support files outside of `/src` and `/test` folders in order to make sure they're not ignored by root .gitignore
simondel
reviewed
Oct 20, 2017
|
|
||
| export default class MochaConfigEditor implements ConfigEditor { | ||
|
|
||
| private log = getLogger('MochaTestRunner'); |
|
I have changed the name of the logger in the MochaConfigEditor because it contained the name of the MochaTestRunner |
|
Cool. That was a mistake indeed. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for some mocha options to be passed to the
mochainstance in the stryker-mocha-runner. The implementation uses aConfigEditorto edit stryker config on the fly.You can either pass a mocha.opts file using
mochaOptions: { opts: 'mocha.opts' }, or pass values directly usingmochaOptions: { ui: 'qunit' }.Closes #417