This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Add strymon terminate sub-command
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends executors with the capability to send a termination signal to their children on request. Termination requests are sent to the coordinator and forwared to all executors participating in a job. On Unix, this results in a SIGTERM signal being sent to the child process. On Windows, this functionality is currently not implemented, but likely be done via `TerminateProcess`. There is currently no restriction on who is allowed to terminate a running job. Closes strymon-system#12 Signed-off-by: Sebastian Wicki <swicki@inf.ethz.ch>
antiguru
reviewed
Nov 28, 2017
| @@ -43,6 +43,14 @@ impl Dispatch { | |||
|
|
|||
| self.handle.spawn(submission); | |||
| } | |||
| "Termination" => { | |||
There was a problem hiding this comment.
Could we use the associated str from rpc here?
Signed-off-by: Moritz Hoffmann <moritz.hoffmann@inf.ethz.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subcommand
strymon terminate <JOB_ID>to send a termination signal to all processes belonging to a job. This PR has not yet been extensively tested, but I wanted get some feedback first since I won't work on this before next week.The change turned out to be a bit more complex than I expected, mostly because an executor needs to perform some book-keeping to be able to serve external termination requests, but it need to clean up this state if the process terminates by itself. The termination request is sent to all participating executors of a job.
On Unix, this the termination signal results in a SIGTERM signal being sent to the child process. On Windows, this functionality is currently not implemented, but likely be done via
TerminateProcess.There is currently no restriction on who is allowed to terminate a running job.
Fixes #12