Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Build on Rust 1.21 stable #20

Merged
merged 3 commits into from Dec 5, 2017
Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented Dec 5, 2017

This commit removes the dependency on the unstable type_name intrinsic
and replaces it with the typename crate. As a result, we finally compile on Rust stable! This replaces #6.

The typename crate is our own alternative to named_type with the following differences:

  • it implements its TypeName trait for all primitive and some std types. More types will be supported in the future, the current version however should be sufficient for all Timely/Differential programs we have written.
  • It's output is compatible with the intrinsic and prints the full type name, i.e. not just std::vec::Vec, but std::vec::Vec<(string::string::String, i32)>

Fixes #4

Sebastian Wicki added 3 commits December 5, 2017 10:15
This commit removes the dependency on the unstable `type_name` intrinsic
and replaces it with the `typename` crate.

Signed-off-by: Sebastian Wicki <swicki@inf.ethz.ch>
Signed-off-by: Sebastian Wicki <swicki@inf.ethz.ch>
Signed-off-by: Sebastian Wicki <swicki@inf.ethz.ch>
Copy link
Member

@antiguru antiguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@gandro
Copy link
Member Author

gandro commented Dec 5, 2017

Thanks!

@gandro gandro merged commit ea2d1d7 into strymon-system:master Dec 5, 2017
@gandro gandro deleted the build-on-stable branch December 5, 2017 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants