This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Spawn processes in executor with tokio-process #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to reduce the number of threads needed when managing spawned jobs. This commit also introduces the use of tokio-process to properly handle SIGTERM in an executor, which drops (and therefore kills) all the child processes upon exit. Signed-off-by: Sebastian Wicki <swicki@inf.ethz.ch>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first PR for the process management, further moving away from using threads and integrating more of tokio.
This PR adds
tokio-{process,signal}as additional dependencies, allowing us to easily handle both SIGCHILD and SIGTERM on Unix executors in a portable way.SIGCHILD is needed such that the spawned queries/jobs are properly reaped by their parent executor upon completion, this was previously done through a dedicated thread calling
Child::wait.SIGTERM has not been handled so far, which meant that jobs would outlive their executor. This PR changes this behaviour such that all spawned jobs are killed (through the drop impl of
tokio-process) when shutting down.