fix: unnecessary remap to select-mode which disturbs nvim-snippy #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`vmap` is used to map `gx` to visual-mode. However, `vmap` not only maps to visual-mode but also select-mode. This is first of all not necessary because `xmap` is enough to map to visual-mode but more importantly it disturbs other plugins which rely on select-mode like `nvim-snippy`. During snippet-expansion snippy selects with the select-mode placeholders which should be overwritten by the user. Typing `g` becomes impossible without pressing another 2nd key because it's remapped by gx-extended. It is generally good practice to use xmap instead of vmap unless necessary.
stsewd
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vmapis used to mapgxto visual-mode. However,vmapnot only maps to visual-mode but also select-mode. This is first of all not necessary becausexmapis enough to map to visual-mode but more importantly it disturbs other plugins which rely on select-mode likenvim-snippy. During snippet-expansion snippy selects with the select-mode placeholders which should be overwritten by the user. Typinggbecomes impossible without pressing another 2nd key because it's remapped by gx-extended. It is generally good practice to use xmap instead of vmap unless necessary.