-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
punctuation_chars.h compilation errors on Windows (MSVC) + Clang #55
Comments
Update: everything works fine on Linux + Clang |
OK, after some digging I have found the following:
It seems to me that the best solution would be to write these characters as integer literals instead of |
Hi @jmacmahon thanks for debugging the problem!
That makes sense, feel free to send a PR if you want! /cc @SilverRainZ in case you have some opinions about this. |
Hi, I was working on a PR but got sidetracked trying to work out why the tests still passed on Windows despite the error - I assumed that there was no CI for Windows hence the error not being caught, but I see that in fact there is CI for Windows, but the tests nevertheless passed. I was able to reproduce the unexpectedly-passing tests on my local Windows machine, but I couldn't work out why they were passing. In fact, I was able to completely delete the So, I can do a PR with my suggested change, but actually I have no way of knowing if it would fix the problem since I can't get the tests to work right. |
@jmacmahon you may be missing running |
Unfortunately the tests still unexpectedly pass even if I do (As an aside, I found that |
Well, why the tests unexpectedly passed on Windows is beyond me, but I have submitted a PR anyway to fix the original problem. |
Hello,
I am setting up tree-sitter on a fresh installation today, and experiencing the following errors:
I'm not too familiar with tree-sitter internals or C, but from some googling I think this
L'\U00010100'
is somehow not correct? Possibly this is related to the fix for #53.Sorry I can't be of more help in diagnosing this - I'm happy to run any tests you might suggest.
I will try and see if the problem is reproducible on Linux + Clang.
The text was updated successfully, but these errors were encountered: