Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace libmp4v2 dependency #13

Open
Maia-Everett opened this issue May 2, 2011 · 3 comments
Open

Replace libmp4v2 dependency #13

Maia-Everett opened this issue May 2, 2011 · 3 comments

Comments

@Maia-Everett
Copy link

Since libmp4v2 is MPL-licensed, easytag cannot legally linked with it: MPL is a GPL-incompatible license. The program will need to be ported to another API for reading and writing MP4 tags, such as GStreamer or libavformat.

@stsquad
Copy link
Owner

stsquad commented May 2, 2011

It's a shame we don't have enough source history to contact people to add a linking exception to the license. Anyway patches are as always welcome. I don't intend to do anything myself as it's not a problem purely from the source code perspective. I'll merge a patch if someone provides one though.

@Maia-Everett
Copy link
Author

Here is a patch replacing libmp4v2 with taglib. It handles only the basic tags, though.

http://paste.ubuntu.com/621883/

@amigadave
Copy link
Contributor

Thanks for the patch, I merged a modified version in the upstream development repository:

http://git.gnome.org/browse/easytag/commit/?id=186439606a8459febb31fdd3631b0ea6a911eb74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants