Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-140392 Publications settings #179

Conversation

Preston-Crary
Copy link

No description provided.

alessiorendina and others added 24 commits October 7, 2021 05:50
…nce add button enabled is taking into account enableTemplateCreation configuration
…thout this the description is rendered as a simple input
As stores are referenced from some core classes, but stores are
located in modules, there are some intermitent errors in the CI that
depend on component initialization errors.

Establish an explicit dependency in this component to force the store
to be enabled before activation of the component.
@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@Preston-Crary
Copy link
Author

Just a couple adjustments, let's rename "save" to "submit" and include a "cancel" button to match what the design team has. Cancel can just redirect back to where the user was before.

@stsquared99
Copy link
Owner

Resent: Preston-Crary#1504

@stsquared99 stsquared99 closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet