better config verification #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify cron values when parsing; also verify depends_on relationships, meaning that we can assume later in the code that there are no cyclic dependencies to get us into recursive trouble. Also remove the `priority` field from the configuration as it's of marginal use since we now have `depends_on` which wasn't present in the original `supervisord` configuration from which this is derived.
rogpeppe
force-pushed
the
017-better-config-verification
branch
from
b5aa53a
to
3825c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify cron values when parsing; also verify depends_on relationships,
meaning that we can assume later in the code that there are no cyclic
dependencies to get us into recursive trouble.
Also remove the
priorityfield from the configuration as it's of marginaluse since we now have
depends_onwhich wasn't present in theoriginal
supervisordconfiguration from which this is derived.