New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info.plist: allow for ports-installed lpass #4

Merged
merged 1 commit into from Aug 8, 2015

Conversation

Projects
None yet
2 participants
@jsquyres
Contributor

jsquyres commented Aug 8, 2015

In each of the scripts, check for /usr/local/bin/lpass or /opt/local/bin/lpass.

Also update your@email.com to your_email@example.com.

I'm not entirely sure which of info.plist or lastpass-cli-alfred-workflow.alfredworkflow needs to be updated, so this commit updates both.

info.plist: allow for ports-installed lpass
In each of the scripts, check for /usr/local/bin/lpass or
/opt/local/bin/lpass.

Also update your@email.com to your_email@example.com.
@stuartcryan

This comment has been minimized.

Show comment
Hide comment
@stuartcryan

stuartcryan Aug 8, 2015

Owner

Howdy my good man, thank you for the input (and both need to be updated so that is awesome).

I will merge this in and release a new version on Packal and the Forums.

(and I love the branch name you used :D)

Owner

stuartcryan commented Aug 8, 2015

Howdy my good man, thank you for the input (and both need to be updated so that is awesome).

I will merge this in and release a new version on Packal and the Forums.

(and I love the branch name you used :D)

stuartcryan added a commit that referenced this pull request Aug 8, 2015

Merge pull request #4 from jsquyres/pr/we-love-macports-too
info.plist: allow for ports-installed lpass

@stuartcryan stuartcryan merged commit b7af05f into stuartcryan:master Aug 8, 2015

@stuartcryan stuartcryan added the bug label Aug 8, 2015

@stuartcryan stuartcryan added this to the Version 1.1 milestone Aug 8, 2015

@stuartcryan stuartcryan self-assigned this Aug 8, 2015

@stuartcryan

This comment has been minimized.

Show comment
Hide comment
@stuartcryan

stuartcryan Aug 8, 2015

Owner

All righty, just to update you on this, I am going to revert the change out of the master branch, however I have merged it in to devel.

I have done this after downloading and testing (granted should have done this first) as I want to change so that we store the username in the OSX Keychain so that it does not get nuked across workflow updates. This is something I have been meaning to do for some time but became apparent when I loaded up the workflow, so I figure I might as well fix this in the first update I push, rather than causing people to have to update their email addresses each time.

I will keep you posted on my progress.

Cheers,
Stuart

Owner

stuartcryan commented Aug 8, 2015

All righty, just to update you on this, I am going to revert the change out of the master branch, however I have merged it in to devel.

I have done this after downloading and testing (granted should have done this first) as I want to change so that we store the username in the OSX Keychain so that it does not get nuked across workflow updates. This is something I have been meaning to do for some time but became apparent when I loaded up the workflow, so I figure I might as well fix this in the first update I push, rather than causing people to have to update their email addresses each time.

I will keep you posted on my progress.

Cheers,
Stuart

@jsquyres

This comment has been minimized.

Show comment
Hide comment
@jsquyres

jsquyres Aug 9, 2015

Contributor

Sweet! Thanks for accepting the PR.

Contributor

jsquyres commented Aug 9, 2015

Sweet! Thanks for accepting the PR.

@jsquyres jsquyres deleted the jsquyres:pr/we-love-macports-too branch Aug 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment