Bugfix. Net::LDAP#bind was ignoring the inbound auth parameter.

Thanks to Kouhei Sutou for spotting this and pointing it out.
stuarthalloway · May 7, 2007 · 64a8240 · 64a8240
1 parent 1b568e8
commit 64a8240
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -36,7 +36,8 @@
   LDAP SearchRequest packets.
 * Added Net::LDAP::Filter#execute, which allows arbitrary processing
   based on LDAP filters.
-
+* Fixed bug in Net::LDAP#bind. We were ignoring the passed-in auth parm.
+  Thanks to Kouhei Sutou for spotting it.
 
 == Net::LDAP 0.0.4: August 15, 2006
 * Undeprecated Net::LDAP#modify. Thanks to Justin Forder for

diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb
@@ -727,7 +727,7 @@ def bind auth=@auth
         @result = @open_connection.bind auth
       else
         conn = Connection.new( :host => @host, :port => @port , :encryption => @encryption)
-        @result = conn.bind @auth
+        @result = conn.bind auth
         conn.close
       end