Skip to content

Commit

Permalink
Merge pull request #48 from mikey179/master
Browse files Browse the repository at this point in the history
upgrade to stubbles-core 3.4.0 and prepare release
  • Loading branch information
mikey179 committed Jan 21, 2014
2 parents 2364bcd + 72afeda commit 8e18726
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 42 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
2.3.3 (2013-12-??)
2.4.0 (2014-01-21)
------------------

* fixed #45 ParamBrokerMap should work with lowercase versions of built-in types as well
Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"description": "Stubbles Input enables to handle input data via validation and filtering.",
"require": {
"php": ">=5.3.0",
"stubbles/core": "~3.1"
"stubbles/core": "~3.4"
},
"require-dev": {
"mikey179/vfsStream": "~1.2",
Expand All @@ -20,7 +20,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "2.3.x-dev"
"dev-master": "2.4.x-dev"
}
},
"minimum-stability": "dev",
Expand Down
60 changes: 30 additions & 30 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions nbproject/project.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_create_2e_tests=false
auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_enabled=true
auxiliary.org-netbeans-modules-php-phpunit.bootstrap_2e_path=vendor/autoload.php
auxiliary.org-netbeans-modules-php-phpunit.configuration_2e_enabled=true
auxiliary.org-netbeans-modules-php-phpunit.configuration_2e_path=phpunit.xml.dist
auxiliary.org-netbeans-modules-php-phpunit.customSuite_2e_enabled=false
auxiliary.org-netbeans-modules-php-phpunit.customSuite_2e_path=
auxiliary.org-netbeans-modules-php-phpunit.phpUnit_2e_enabled=false
auxiliary.org-netbeans-modules-php-phpunit.phpUnit_2e_path=
auxiliary.org-netbeans-modules-php-phpunit.test_2e_groups_2e_ask=false
auxiliary.org-netbeans-modules-php-phpunit.test_2e_run_2e_all=false
file.reference.docs-api=docs/api
file.reference.src-test=vendor/stubbles/core/src/test
file.reference.src-test-1=vendor/mikey179/vfsStream/src/test
Expand All @@ -8,15 +19,10 @@ ignore.path=\
include.path=\
${php.global.include.path}
php.version=PHP_53
phpunit.bootstrap=vendor/autoload.php
phpunit.bootstrap.create.tests=false
phpunit.configuration=phpunit.xml.dist
phpunit.run.test.files=false
phpunit.suite=
phpunit.test.groups.ask=false
source.encoding=UTF-8
src.dir=.
tags.asp=false
tags.short=true
test.src.dir=src/test/php
testing.providers=PhpUnit
web.root=.
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function __construct(ResourceLoader $resourceLoader)
* @param string $locale
* @return PropertyBasedParamErrorMessages
* @Inject(optional=true)
* @Named('net.stubbles.locale')
* @Property('net.stubbles.locale')
*/
public function setLocale($locale)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,9 @@ public function annotationsPresentOnSetLocaleMethod()
$setLocaleMethod = lang\reflect($this->errorMessages, 'setLocale');
$this->assertTrue($setLocaleMethod->hasAnnotation('Inject'));
$this->assertTrue($setLocaleMethod->getAnnotation('Inject')->isOptional());
$this->assertTrue($setLocaleMethod->hasAnnotation('Named'));
$this->assertTrue($setLocaleMethod->hasAnnotation('Property'));
$this->assertEquals('net.stubbles.locale',
$setLocaleMethod->getAnnotation('Named')->getName()
$setLocaleMethod->getAnnotation('Property')->getValue()
);
}
}
Expand Down

0 comments on commit 8e18726

Please sign in to comment.