Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out RecordService component, in prep for enabling recording services in database #124

Merged
merged 6 commits into from Feb 24, 2016

Conversation

kevinrobinson
Copy link
Contributor

This is part of #115 and #5.

This refactors the UI code for recording a new service into its own component and adds some basic specs for it.

No visual or functional regressions (although "Save" is still intentionally disabled until the backend pieces are ready):
screen shot 2016-02-24 at 12 53 12 pm

This also led to some cleanup in InterventionsDetails, which can ultimately be simplified or factored further as part of the additional steps in #115.

@kevinrobinson
Copy link
Contributor Author

@BWieber this is the first piece of the UI code for #115.

Also, this uses the following placeholder ids for the service_types right now:

{
  502: 'Attendance Officer',
  503: 'Attendance Contract',
  504: 'Behavior Contract',
  505: 'Counseling, in-house',
  506: 'Counseling, outside',
  507: 'Reading intervention',
  508: 'Math intervention'
}

You can use the same values on the server side and things will just work, or if you end up using different values that's cool and I can update these ids later to match. 👍 either way!

@kevinrobinson kevinrobinson modified the milestones: February Sprint 1, Kevin + Alex Spring Project Plan Feb 24, 2016
@kevinrobinson kevinrobinson self-assigned this Feb 24, 2016
kevinrobinson added a commit that referenced this pull request Feb 24, 2016
…services

Factor out RecordService component, in prep for enabling recording services in database
@kevinrobinson kevinrobinson merged commit 0be5a4a into master Feb 24, 2016
@kevinrobinson kevinrobinson deleted the refactor/fluxify-saving-services branch February 24, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant