Cross-browser styling fixes: layout, SVG overflow and profile v2 buttons #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also applies a |
kevinrobinson
added a commit
that referenced
this pull request
Feb 25, 2016
…ut-and-styling Cross-browser styling fixes: layout, SVG overflow and profile v2 buttons
|
Confirmed this looks good on browserstack with:
I forgot to fix the width of the columns for buttons on the notes tab though, will address that separately: |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of improvements here, tested locally on Safari. The actual issue is IE compatibility, so I'll test those on browserstack on the demo site after merging.
IE11 in browserstack, before:
#### Safari before, SVG paths overflowing:
#### Safari after, no overflow:
#### Safari after, columns for buttons fixed width:
#### Safari/Chrome after, showing changes in profile v2 layout flexing: