Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add school, educator and student grade levels to Homeroom page #2032

Merged
merged 5 commits into from Aug 30, 2018

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Aug 28, 2018

Who is this PR for?

K8 educators

What problem does this PR fix?

Data quality issues around homeroom assignments and grade levels are a bit hidden. Related to #1939.

What does this PR do?

Adds in more info to the homeroom page, adjusts layout.

Screenshot (if adding a client-side feature)

before

screen shot 2018-08-28 at 12 04 52 pm

after

screen shot 2018-08-28 at 11 58 40 am

Checklists

  • Author checked latest in IE - Homeroom page
  • Author included specs for new code

@kevinrobinson
Copy link
Contributor Author

This PR also removes the link to the school page, and does the same for the profile v3 page. Only some users can access these right now. Later, we should update the school roster page to use the core authorizer code, and then we can allow anyone to use those pages (scoped to which students they have access to). Or we could rework those pages to be more meaningful (sort of a day-to-day overview of the school using pieces of the home page, feed and my students that we have now). But all out of scope for now, so removing the links.

@kevinrobinson
Copy link
Contributor Author

selfie

@kevinrobinson kevinrobinson merged commit dc3b4d2 into master Aug 30, 2018
@kevinrobinson kevinrobinson deleted the feature/homeroom-more-info branch August 30, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant