Update overview panels to show Services instead of Interventions #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #5.
This includes the main functional change and two other related improvements:
School overview shows Services instead of Interventions
The main functional change is updating the school overview page from this:
to this:
Fix STAR Reading slice panels
In the process of making this change, there is a bunch of related cleanup and improvements. These include fixing up the related code for the STAR reading page, where there were regressions in the different ways users could slice cohorts of students (which had gone unnoticed since this isn't fully productionized yet):
STAR reading before:
STAR reading after:
Doing this simplified some code in
schools_controller
, and the factoring there splits the query that we can precompute daily (as part of #3) and the query for data that is likely to change more frequently.Stricter serialization when sending indexes to UI
It also updates the serialization code for constant indexes in
serialize_data_helper
to filter out the fields we send down to the client. Forservice_types_index
and other constants this just removes noise, but foreducators_index
it also stops exposing some mildly-sensitive information about other users (like their access level and potentially their phone number).Before:
After: