Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview panels to show Services instead of Interventions #212

Merged
merged 8 commits into from Mar 19, 2016

Conversation

kevinrobinson
Copy link
Contributor

This is part of #5.

This includes the main functional change and two other related improvements:

  • update school overview page to show Services instead of Interventions
  • fix STAR Reading slice panels
  • stricter serialization when sending indexes to UI

School overview shows Services instead of Interventions

The main functional change is updating the school overview page from this:
screen shot 2016-03-19 at 12 27 55 pm
screen shot 2016-03-19 at 3 15 58 pm

to this:
screen shot 2016-03-19 at 2 05 15 pm
screen shot 2016-03-19 at 3 15 51 pm

Fix STAR Reading slice panels

In the process of making this change, there is a bunch of related cleanup and improvements. These include fixing up the related code for the STAR reading page, where there were regressions in the different ways users could slice cohorts of students (which had gone unnoticed since this isn't fully productionized yet):

STAR reading before:
screen shot 2016-03-19 at 2 06 25 pm

STAR reading after:
screen shot 2016-03-19 at 2 06 12 pm

Doing this simplified some code in schools_controller, and the factoring there splits the query that we can precompute daily (as part of #3) and the query for data that is likely to change more frequently.

Stricter serialization when sending indexes to UI

It also updates the serialization code for constant indexes in serialize_data_helper to filter out the fields we send down to the client. For service_types_index and other constants this just removes noise, but for educators_index it also stops exposing some mildly-sensitive information about other users (like their access level and potentially their phone number).

Before:
screen shot 2016-03-19 at 2 00 55 pm

After:
screen shot 2016-03-19 at 2 01 14 pm

@kevinrobinson kevinrobinson temporarily deployed to somerville-teacher-tool-demo March 19, 2016 19:13 Inactive
kevinrobinson added a commit that referenced this pull request Mar 19, 2016
…s-and-notes

Update overview panels to show Services instead of Interventions
@kevinrobinson kevinrobinson merged commit 43d5198 into master Mar 19, 2016
@kevinrobinson kevinrobinson deleted the feature/overview-services-and-notes branch March 19, 2016 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant