Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Font loader #2263

Merged
merged 3 commits into from Nov 21, 2018
Merged

Remove Google Font loader #2263

merged 3 commits into from Nov 21, 2018

Conversation

@kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Nov 21, 2018

Removing dependency on external services and whitelisting in CSP. We can distribute these to a CDN separately, and if they load a few more bits the first time they are cached that's a good tradeoff to be able to control this ourselves.

@kevinrobinson
Copy link
Contributor Author

@kevinrobinson kevinrobinson commented Nov 21, 2018

selfie

@kevinrobinson kevinrobinson merged commit 5fe9334 into master Nov 21, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@studentinsights-bot
Copy link

@studentinsights-bot studentinsights-bot commented Nov 21, 2018

@kevinrobinson, this looks like it might be worth double-checking! @kevinrobinson might be able to help.

@kevinrobinson kevinrobinson deleted the feature/remove-google-fonts branch Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants