Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
developers
What problem does this PR fix?
Enforces test coverage on particularly critical files. This of course is not a great measure of code quality or even test quality, but for these files we have this level of coverage now and this can help us spot gaps if they are introduced.
What does this PR do?
Fails CI if test coverage for particular files is not 100%. It can be run locally with
ENABLE_RSPEC_COVERAGE_CHECKER
. Also adds some test cases toauthorizer.rb
and fixes a typo in mentionbot.Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?