Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile PDF: Update to allow restricted notes, revise styling and layout #2424

Merged
merged 5 commits into from Mar 5, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Mar 5, 2019

Who is this PR for?

educators

What problem does this PR fix?

If educator wants to print out all data in the record, this doesn't include restricted notes now, even if they have access.

The layout of the PDF is hard to read across page breaks.

What does this PR do?

Updates the dialog to allow exporting restricted notes only if the user has access, and updates the <label /> elements so that they are clickable.

Updates layout to add clearer headers and page breaks. Also updates some header text, and some of the info in notes and services.

Screenshot (if adding a client-side feature)

before, dialog

image

after, dialog

image

before, report

before.pdf

screen shot 2019-03-05 at 1 15 06 pm

screen shot 2019-03-05 at 1 15 09 pm

after, report

after.pdf
image

image

image

image

image

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson kevinrobinson merged commit e60ddb5 into master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevinrobinson kevinrobinson deleted the feature/pdf-export-allow-restricted branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.