Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader profile: Initial prototype for design work #2493

Merged
merged 46 commits into from Jun 6, 2019

Conversation

Projects
None yet
1 participant
@kevinrobinson
Copy link
Contributor

commented Jun 6, 2019

Who is this PR for?

Folks working with K1 students

What problem does this PR fix?

Pulling together different data sources about early reading, and putting them in a frame that can help discussion protocols (eg, in MTSS).

What does this PR do?

Adds a reader profile inline to the "Reading" tab of the profile for students. It's behind a label, and contains its own error boundary to isolate it and let us iterate in ways that allow educators to critique this with production data for real students.

One new element is the pdf-reader gem for parsing IEP PDF documents as text, and some prototype-quality regular expressions cleaning that. Another is adding lunr in JS to do searches within note and IEP documents, and this is also only prototype-quality at this point.

This PR factors out <CleanSlateFeedView /> from the <InlineStudentProfile /> for class lists, to re-use it here, and refactors the counselor meeting page to use this as well.

There are many design elements that are still prototype-quality or experimental, and the assumption is that this will change significantly over the summer before the fall.

Screenshot (if adding a client-side feature)

Minimal:
Screen Shot 2019-06-06 at 11 48 02 AM

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

selfie

@kevinrobinson kevinrobinson merged commit a6f5650 into master Jun 6, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kevinrobinson kevinrobinson deleted the feature/reader-profile-june branch Jun 6, 2019

@kevinrobinson kevinrobinson referenced this pull request Jun 6, 2019

Merged

Reader profile: Some style and visual tweaks #2494

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.