New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader profile: Initial prototype for design work #2493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfie |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
Folks working with K1 students
What problem does this PR fix?
Pulling together different data sources about early reading, and putting them in a frame that can help discussion protocols (eg, in MTSS).
What does this PR do?
Adds a reader profile inline to the "Reading" tab of the profile for students. It's behind a label, and contains its own error boundary to isolate it and let us iterate in ways that allow educators to critique this with production data for real students.
One new element is the
pdf-reader
gem for parsing IEP PDF documents as text, and some prototype-quality regular expressions cleaning that. Another is addinglunr
in JS to do searches within note and IEP documents, and this is also only prototype-quality at this point.This PR factors out
<CleanSlateFeedView />
from the<InlineStudentProfile />
for class lists, to re-use it here, and refactors the counselor meeting page to use this as well.There are many design elements that are still prototype-quality or experimental, and the assumption is that this will change significantly over the summer before the fall.
Screenshot (if adding a client-side feature)
Minimal:
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?