Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counselor meetings: Update inline profile to have clearer links to full profile #2552

Merged
merged 1 commit into from Aug 27, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
45 changes: 33 additions & 12 deletions app/assets/javascripts/counselor_meetings/CounselorMeetingsView.js
Expand Up @@ -286,11 +286,17 @@ export default class CounselorMeetingsView extends React.Component {
const feedCards = json.feed_cards;
return (
<div style={{background: 'white', fontSize: 14}}>
<StudentPhoto
style={{height: 200, border: '2px solid #1b82ea'}}
student={student}
fallbackEl={<span>😃</span>}
/>
<a
href={`/students/${student.id}`}
target="_blank"
rel="noopener noreferrer"
>
<StudentPhoto
style={{height: 200, border: '2px solid #1b82ea'}}
student={student}
fallbackEl={<span>😃</span>}
/>
</a>
<div style={{
display: 'flex',
flexDirection: 'row'
Expand All @@ -302,15 +308,30 @@ export default class CounselorMeetingsView extends React.Component {
}}>
{this.renderBubble(student.meetingMoment)}
</div>
<div style={{
marginLeft: 10,
fontSize: 24,
marginTop: 5
}}> {student.first_name} {student.last_name}</div>
<a
href={`/students/${student.id}`}
target="_blank"
rel="noopener noreferrer"
style={{
marginLeft: 10,
fontSize: 24,
marginTop: 5
}}> {student.first_name} {student.last_name}</a>
</div>

<SectionHeading style={{marginTop: 15}}>
Notes for {student.first_name}
<SectionHeading
style={{marginTop: 15}}
titleStyle={{
display: 'flex',
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center'
}}
>
<div>Notes for {student.first_name}</div>
<a style={{fontSize: 14}} href={`/students/${student.id}`} target="_blank" rel="noopener noreferrer">
Open profile
</a>
</SectionHeading>
<CleanSlateFeedView feedCards={feedCards} />
</div>
Expand Down