Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page feed: Show homerooms for all schools but SHS #2568

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@kevinrobinson
Copy link
Contributor

kevinrobinson commented Aug 29, 2019

Who is this PR for?

FC students, educators

What problem does this PR fix?

For SHS, homerooms are administrative and not super meaningful, and this previously was removed from the home page feed. But it was done by checking for high schools, when it should have been more tightly scoped. This led to homeroom and teacher info not being shown in the feed for FC students.

What does this PR do?

Updates the check to only hide for SHS in Somerville in particular.

Checklists

Which features or pages does this PR touch?

  • Home page
  • Student Profile
  • My Notes

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
@kevinrobinson

This comment has been minimized.

Copy link
Contributor Author

kevinrobinson commented Aug 29, 2019

selfie

@kevinrobinson kevinrobinson merged commit b5a8e2e into master Aug 29, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kevinrobinson kevinrobinson deleted the patch/homeroom-meaningful-fc branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.