Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak stylish newsfeed -- aligning event-type badges for easier scanning #400

Merged
merged 2 commits into from
Apr 19, 2016

Conversation

erose
Copy link
Contributor

@erose erose commented Apr 18, 2016

screen shot 2016-04-18 at 1 21 12 pm

Fixes #219. I hope display: 'inline-block' is well-behaved on all browsers, I've heard it might not be

So we should test this on IE. (I don't know how to use BrowserStack right now, but it would be cool to learn!)

@kevinrobinson
Copy link
Contributor

@erose nice, awesome improvement! 👍

There's no problem with using display: inline-block in IE, but it's great to think of this and check layout-type changes on IE! I can help check this tomorrow, but if you want to give browserstack a spin, just visit https://www.browserstack.com/, sign up and then click on IE11 on the latest version of Windows. Then you can visit the demo site in IE within the browser, and sign in with the demo account.

I think at the moment only @alexsoble and I can deploy branches to the demo site without merging to master, but we could talk through that and change it tomorrow too. Or since we're pretty confidence this change will be good, you could merge optimistically then verify on browserstack.

@erose
Copy link
Contributor Author

erose commented Apr 18, 2016

Okay, cool, looks pretty easy. I'll merge optimistically and check.

@erose erose merged commit e44d192 into studentinsights:master Apr 19, 2016
@erose erose deleted the tweak_stylish_newsfeed branch April 30, 2016 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants