-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG/FEATURE] OneDrive Support #68
Labels
Comments
Related information:
One of the current workarounds:
|
Thanks for all the references @bai-jie! |
chripo
added a commit
that referenced
this issue
Feb 3, 2023
The main goal was to simplify the `req` method in `request.go` and making it easier to add more authentication methods. All the magic went into the `auth.go` file. This feature introduces an `Authorizer` which acts as an `Authenticator` factory. Under the hood it creates an authenticator shim per request, which delegates the authentication flow to our authenticators. The authentication flow itself is broken down into `Authorize' and `Verify' steps to encapsulate and control complex authentication challenges. Furthermore, the default `NewAutoAuth' authenticator can be overridden by a custom implementation for more control over flow and resources. The `NewBacisAuth` Authorizer gives us the feel of the old days.
chripo
added a commit
that referenced
this issue
Feb 3, 2023
The main goal was to simplify the `req` method in `request.go` and making it easier to add more authentication methods. All the magic went into the `auth.go` file. This feature introduces an `Authorizer` which acts as an `Authenticator` factory. Under the hood it creates an authenticator shim per request, which delegates the authentication flow to our authenticators. The authentication flow itself is broken down into `Authorize' and `Verify' steps to encapsulate and control complex authentication challenges. Furthermore, the default `NewAutoAuth' authenticator can be overridden by a custom implementation for more control over flow and resources. The `NewBacisAuth` Authorizer gives us the feel of the old days.
chripo
added a commit
that referenced
this issue
Feb 3, 2023
The main goal was to simplify the `req` method in `request.go` and making it easier to add more authentication methods. All the magic went into the `auth.go` file. This feature introduces an `Authorizer` which acts as an `Authenticator` factory. Under the hood it creates an authenticator shim per request, which delegates the authentication flow to our authenticators. The authentication flow itself is broken down into `Authorize' and `Verify' steps to encapsulate and control complex authentication challenges. Furthermore, the default `NewAutoAuth` authenticator can be overridden by a custom implementation for more control over flow and resources. The `NewBacisAuth` Authorizer gives us the feel of the old days.
chripo
added a commit
that referenced
this issue
Feb 3, 2023
The main goal was to simplify the `req` method in `request.go` and making it easier to add more authentication methods. All the magic went into the `auth.go` file. This feature introduces an `Authorizer` which acts as an `Authenticator` factory. Under the hood it creates an authenticator shim per request, which delegates the authentication flow to our authenticators. The authentication flow itself is broken down into `Authorize` and `Verify' steps to encapsulate and control complex authentication challenges. Furthermore, the default `NewAutoAuth` authenticator can be overridden by a custom implementation for more control over flow and resources. The `NewBacisAuth` Authorizer gives us the feel of the old days.
chripo
added a commit
that referenced
this issue
Feb 3, 2023
The main goal was to simplify the `req` method in `request.go` and making it easier to add more authentication methods. All the magic went into the `auth.go` file. This feature introduces an `Authorizer` which acts as an `Authenticator` factory. Under the hood it creates an authenticator shim per request, which delegates the authentication flow to our authenticators. The authentication flow itself is broken down into `Authorize` and `Verify' steps to encapsulate and control complex authentication challenges. Furthermore, the default `NewAutoAuth` authenticator can be overridden by a custom implementation for more control over flow and resources. The `NewBacisAuth` Authorizer gives us the feel of the old days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello Collaborators,
Describe the bug
When using OneDrive as the WebDav server things get weird. In short: The authentication fails because of Microsoft.
Software
To Reproduce
ReadDir()
)Expected
At least an authentication error should be returned. Even better would be support for MS's need to be proprietary.
Additional context
Microsoft (as expected) does not follow industry standards and instead of returning
401
on unauthenticated requests they return302
to redirect you to the login page. The login page then return a200
status so the webdav client thinks it is a valid result for the original request. On its own this would not be too bad as you could catch the redirect and handle it like a401
. But since Microsoft use their own authentication method (MS-PASS withPassport1.4
) you also need a new authenticator.The text was updated successfully, but these errors were encountered: