Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest installable languages based on Laravel Lang #355

Merged
merged 27 commits into from Nov 27, 2023

Conversation

marcorieser
Copy link
Contributor

@marcorieser marcorieser commented Nov 1, 2023

Changes proposed in this pull request:

  • Suggest installable languages based on Laravel Lang

Idea for future:
Instead of cleaning up PostInstallCommands and uninstalling Composer packages inside the starter kit itself, we could delegate that to a specific addon which gets uninstalled at the end.

@marcorieser
Copy link
Contributor Author

Memo for myself:
Current state of knowledge is that after installing a Composer package a new instance of the app is needed to boot the autoloading freshly. Maybe thats what the registerCommands is for: https://github.com/statamic/cms/blob/b6f37d357fa5e58763d9f9d362d86f9f9efc65f8/src/StarterKits/Installer.php#L512-L518

@marcorieser
Copy link
Contributor Author

For reference: statamic/cms#6807

Lokman: Its mostly used if you want to run commands after a Starter Kit has been installed. For example you want to move dirs, or check if a configuration file exists.

@marcorieser marcorieser marked this pull request as ready for review November 27, 2023 10:23
@robdekort
Copy link
Contributor

Amazing!

@robdekort robdekort merged commit 059e88f into studio1902:main Nov 27, 2023
1 check passed
@marcorieser marcorieser deleted the suggest-installable-languages branch November 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants