Check methods before calling

[joshuabaker]

Fixes #257.

Key aim here is to prevent the Calling unknown method errors that keep surfacing. It’s assumed that this is a result of other plugins clashing in some manner.

The solution is guarding the behavior method calls with method_exists.

[janhenckens]

Hey @joshuabaker, thanks for the PR. That's probably the only thing we can do in Scout to prevent crashes.

Did you intentionally make this for the Craft 3 branch? I'll release it for both version but just checking.
Thanks!

[joshuabaker]

Thanks, @janhenckens.

I actually just assumed the Craft 4 version was a rewrite. Feel free to just cheery pick/copy and paste my changes, and discard this PR if that’s easier.

[janhenckens]

Wish it was a rewrite but haven't been able to spend much, if any, time on the plugin.
I'll make sure it get's merged for 3 & 4!

[janhenckens]

@joshuabaker This is out for Craft 4 in 3.1.1. The Craft 3 branch is bit diverged so still looking at merging it there.

[joshuabaker]

Hey @janhenckens. Is this in the Craft 3 branch yet?

[janhenckens]

Not yet.

I have a beta version out for Craft 3 that moves the initial "Should we index this element" check to a queue job. If you're good with that I can merge it there and make a new release right away.

[joshuabaker]

Oh, you’ve merged features in this PR. I didn’t realise that. 😅

There’s a $element->searchable(); call in the middle of the IndexElement. Guessing that might suffer the same issue raised in #257, right?