Make SearchableBehavior::getRelatedElements() configurable
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapease
force-pushed
the
configurable-related-elements
branch
from
8f68b97
to
c034ace
Compare
|
Tested and this looks good to go @joshuapease. I'll get this into the Craft 4 version so you can hopefully "just" upgrade to 5 :) |
|
No way! This made my Friday! |
|
Cheers @joshuapease, thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bringing ticket #242 is back from the dead.
I'm working on a Craft Commerce site with about
250,000650,000 SKUs.At that scale, we hit memory limit exceeded errors for some of our Entries that have lots of relationships to Products.
Commenting out these lines in SearchableBehavior::getRelatedElements resolved our issue.
This got me thinking... for many use cases, checking all of these Element Types is overkill. Most of our indexes only have relations between Entry and Asset elements.
Our project still need to index relations, but by removing most Element types from that check, we improve our performance by quite a bit.